Lech Perczak <lech.perczak@xxxxxxxxx> writes: > Reporting of bogus MAC addresses and ignoring configuration of new > destination address wasn't observed outside of a range of ZTE devices, > among which this seems to be the common bug. Align rndis_host driver > with implementation found in cdc_ether, which also limits this workaround > to ZTE devices. Reviewed-by: Bjørn Mork <bjorn@xxxxxxx> Yes, this is a much better solution. We have no business rejecting the address chosen by the device, even if it is "locally administered". The device has every right to use a local address on a link with no other devices, which is the case for every cellular modem for example. And even if we believe the device is wrong there isn't much we can do about that. Rejecting the device address, with no way to inform the device about a new address, implies that host and device disagrees about it. This does not fix anything. It just makes the host to silentlig drop all packets, leaving the user with a non-working device. I take full responibility for coming up with the idea of over- simplifying the original workaround proposed by Kristian. It wasn't very well thought over. Thanks to Lech for fixing this! Bjørn
