Hi, It appears these role swapping routines have been broken for a while. The role swap UCSI commands always actually did work, and the roles were most likely always swapped, but these operations just always appeared to fail because of these bugs. I'm guessing that has kept the problem hidden. Nobody cared about the return values from these operations. It was enough that the roles were swapped in the end. thanks, Heikki Krogerus (2): usb: typec: ucsi: Fix reuse of completion structure usb: typec: ucsi: Fix role swapping drivers/usb/typec/ucsi/ucsi.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) -- 2.35.1
