Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.18-rc1 next-20220404] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Michael-Grzeschik/usb-gadget-uvc-fixes-and-improvements/20220404-165031 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: arm64-randconfig-r016-20220404 (https://download.01.org/0day-ci/archive/20220404/202204041903.wSoTM3yH-lkp@xxxxxxxxx/config) compiler: aarch64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/3577e91e5a0a9a94ee3d4b22240e7b143c31133c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Michael-Grzeschik/usb-gadget-uvc-fixes-and-improvements/20220404-165031 git checkout 3577e91e5a0a9a94ee3d4b22240e7b143c31133c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/usb/gadget/function/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/usb/gadget/function/uvc_video.c: In function 'uvcg_video_pump': >> drivers/usb/gadget/function/uvc_video.c:371:74: error: 'struct uvc_device' has no member named 'streamon' 371 | while (video->ep->enabled || queue->queue.streaming || video->uvc->streamon) { | ^~ vim +371 drivers/usb/gadget/function/uvc_video.c 351 352 /* -------------------------------------------------------------------------- 353 * Video streaming 354 */ 355 356 /* 357 * uvcg_video_pump - Pump video data into the USB requests 358 * 359 * This function fills the available USB requests (listed in req_free) with 360 * video data from the queued buffers. 361 */ 362 static void uvcg_video_pump(struct work_struct *work) 363 { 364 struct uvc_video *video = container_of(work, struct uvc_video, pump); 365 struct uvc_video_queue *queue = &video->queue; 366 struct usb_request *req = NULL; 367 struct uvc_buffer *buf; 368 unsigned long flags; 369 int ret; 370 > 371 while (video->ep->enabled || queue->queue.streaming || video->uvc->streamon) { 372 /* Retrieve the first available USB request, protected by the 373 * request lock. 374 */ 375 spin_lock_irqsave(&video->req_lock, flags); 376 if (list_empty(&video->req_free)) { 377 spin_unlock_irqrestore(&video->req_lock, flags); 378 return; 379 } 380 req = list_first_entry(&video->req_free, struct usb_request, 381 list); 382 list_del(&req->list); 383 spin_unlock_irqrestore(&video->req_lock, flags); 384 385 /* Retrieve the first available video buffer and fill the 386 * request, protected by the video queue irqlock. 387 */ 388 spin_lock_irqsave(&queue->irqlock, flags); 389 buf = uvcg_queue_head(queue); 390 if (buf == NULL) { 391 spin_unlock_irqrestore(&queue->irqlock, flags); 392 break; 393 } 394 395 video->encode(req, video, buf); 396 397 /* With usb3 we have more requests. This will decrease the 398 * interrupt load to a quarter but also catches the corner 399 * cases, which needs to be handled */ 400 if (list_empty(&video->req_free) || 401 buf->state == UVC_BUF_STATE_DONE || 402 !(video->req_int_count % 403 DIV_ROUND_UP(video->uvc_num_requests, 4))) { 404 video->req_int_count = 0; 405 req->no_interrupt = 0; 406 } else { 407 req->no_interrupt = 1; 408 } 409 410 /* Queue the USB request */ 411 ret = uvcg_video_ep_queue(video, req); 412 spin_unlock_irqrestore(&queue->irqlock, flags); 413 414 if (ret < 0) { 415 uvcg_queue_cancel(queue, 0); 416 break; 417 } 418 video->req_int_count++; 419 } 420 421 if (!req) 422 return; 423 424 spin_lock_irqsave(&video->req_lock, flags); 425 list_add_tail(&req->list, &video->req_free); 426 spin_unlock_irqrestore(&video->req_lock, flags); 427 return; 428 } 429 -- 0-DAY CI Kernel Test Service https://01.org/lkp
