On Mon, Sep 21, 2009 at 12:38 PM, Julie Zhu <julie.zhu@xxxxxxxxxx> wrote:
> Add bus glue driver for Xilinx USB host controller. The controller can be
> configured as HS only or HS/FS hybrid. The driver uses the device tree file
> to configure the driver according to the setting in the hardware system.
Looks good, one minor nit....
> +static struct of_device_id ehci_hcd_xilinx_of_match[] = {
> + {.compatible = "xlnx,xps-usb-host-1.00.a",},
> + {.compatible = "xlnx,xps-usb-host-1.01.a",},
> + {.compatible = "xlnx,xps-usb-host-1.02.a",},
> + {},
> +};
Ideally, 1.01 and 1.02 device tree nodes would also claim
compatibility with the original 1.00.a version (assuming of course
that it really is register level compatible) making the 2nd and 3rd
lines redundant, but that's just a minor nit and this doesn't hurt
anything. Do what you prefer.
Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
