Hi, On Thu, Mar 17, 2022 at 04:45:11PM +0100, Sebastian Krzyszkowiak wrote: > This is a series developed for the Librem 5 phone, which uses TPS65982 > as its USB-C controller. Implemented are Power Delivery sink contract > tracing and exporting negotiated power values as power supply properties, > fixes for data role swapping, status register caching and a debugfs entry > for querying customer use word of the firmware running on the controller. > > Angus Ainslie (3): > usb: typec: tipd: set the data role on tps IRQ > usb: typec: tipd: Add trace event for SINK PD contract > usb: typec: tipd: Provide POWER_SUPPLY_PROP_{CURRENT,VOLTAGE}_MAX > > Guido Günther (2): > usb: typec: tipd: Only update power status on IRQ > usb: typec: tipd: Add debugfs entries for customer use word > > Sebastian Krzyszkowiak (2): > usb: typec: tipd: Provide POWER_SUPPLY_PROP_PRESENT > usb: typec: tipd: Fail probe when the controller is in BOOT mode > > drivers/usb/typec/tipd/core.c | 263 ++++++++++++++++++++++++++---- > drivers/usb/typec/tipd/tps6598x.h | 30 ++++ > drivers/usb/typec/tipd/trace.h | 38 +++++ > 3 files changed, 302 insertions(+), 29 deletions(-) These look pretty good to me. I'll see if I can test these on Monday - I finally have access to a machine again that actually has TI PD controller. But I will give my comments then in any case, if there is anything to comment. But related to patch 3/7, there is a series in works that would expose the PDOs in sysfs [1]. I was wondering have you guys noticed it, and would that actually work also in your case? [1] https://lore.kernel.org/linux-usb/20220203144657.16527-1-heikki.krogerus@xxxxxxxxxxxxxxx/ Br, -- heikki