Thanks, Grant and Ben,
> > Add bus glue driver for Xilinx USB host controller. The controller can
> be
> > configured as HS only or HS/FS hybrid. The driver uses the device tree
> file
> > to configure the driver according to the setting in the hardware system.
> >
> > This driver has been tested with usbtest using the NET2280 PCI card.
> >
> > Signed-off-by: Julie Zhu <julie.zhu@xxxxxxxxxx>
>
> As Ben said, this is nice tight code. Two comments below.
>
> > +/**
> > + * ehci_xilinx_port_handed_over - hand the port out if failed to enable
> it
> > + * @hcd: Pointer to the usb_hcd device to which the host
> controller bound
> > + * @portnum:Port number to which the device is attached.
> > + *
> > + * This function is used as a place to tell the user that the Xilinx
> USB host
> > + * controller does support LS devices. And in an HS only configuration,
> it
> > + * does not support FS devices neither. It is hoped that this can help
> a
>
> s/neither/either
>
> [...]
> > +static struct of_device_id ehci_hcd_xilinx_of_match[] = {
> > + {
> > + .compatible = "usb-ehci",
> > + },
>
> This looks wrong. Since this driver only works with Xilinx USB
> controllers,
> it should be binding against "xlnx,xps-usb-host-1.00.a", and the meaning
> of
> that binding needs to be documented in Documentation/powerpc/dts-bindings.
>
I have changed the compatible to "xlnx,xps-usb-host-1.00.a", thanks for catching this.
Where should I put the binding for Xilinx USB host controller? usb-ehci.txt or xilinx.txt?
Thanks,
Julie.
> Having this driver bind against the generic "usb-ehci" will cause
> conflicts
> with the ehci-ppc-of driver.
>
> Cheers,
> g.
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
