RE: [PATCH 4/5] USB: Add EHCI support for MX27 and MX31 based boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The Freescale MX27 and MX31 SoCs have a EHCI controller onboard.
> The controller is capable of USB on the go. This patch adds
> a driver to support all three of them.
> 
> Users have to pass details about serial interface configuration in the
> platform data.
> 
> The USB OTG core used here is the ARC core, so the driver should
> be renamed and probably be merged with ehci-fsl.c eventually.
> 
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> ---
>  arch/arm/plat-mxc/Makefile                |    2 +
>  arch/arm/plat-mxc/ehci.c                  |   90 +++++++++
>  arch/arm/plat-mxc/include/mach/mxc_ehci.h |   37 ++++
>  drivers/usb/Kconfig                       |    1 +
>  drivers/usb/host/Kconfig                  |    7 +
>  drivers/usb/host/ehci-hcd.c               |    5 +
>  drivers/usb/host/ehci-mxc.c               |  296 +++++++++++++++++++++++++++++
>  7 files changed, 438 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/plat-mxc/ehci.c
>  create mode 100644 arch/arm/plat-mxc/include/mach/mxc_ehci.h
>  create mode 100644 drivers/usb/host/ehci-mxc.c

<snip>

> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> new file mode 100644
> index 0000000..35c56f4
> --- /dev/null
> +++ b/drivers/usb/host/ehci-mxc.c

<snip>

> +static int ehci_mxc_drv_probe(struct platform_device *pdev)
> +{
> +	struct mxc_usbh_platform_data *pdata = pdev->dev.platform_data;
> +	struct usb_hcd *hcd;
> +	struct resource *res;
> +	int irq, ret, temp;
> +	struct ehci_mxc_priv *priv;
> +	struct device *dev = &pdev->dev;
> +
> +	dev_info(&pdev->dev, "initializing i.MX USB Controller\n");
> +

You probably need to return an error if usb_disabled()

Sorry for the late catch.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux