On Mon, Mar 07, 2022 at 11:07:04AM +0100, Krzysztof Kozlowski wrote: > On 04/03/2022 07:23, Daehwan Jung wrote: > > Signed-off-by: Daehwan Jung <dh10.jung@xxxxxxxxxxx> > > +Cc Randy, > I guess here is the rest of the patches. > > > --- > > drivers/usb/host/xhci-exynos.c | 2025 ++++++++++++++++++++++++++++++++ > > drivers/usb/host/xhci-exynos.h | 150 +++ > > 2 files changed, 2175 insertions(+) > > create mode 100644 drivers/usb/host/xhci-exynos.c > > create mode 100644 drivers/usb/host/xhci-exynos.h > > > > diff --git a/drivers/usb/host/xhci-exynos.c b/drivers/usb/host/xhci-exynos.c > > new file mode 100644 > > index 000000000000..3913c48d4b20 > > --- /dev/null > > +++ b/drivers/usb/host/xhci-exynos.c > > @@ -0,0 +1,2025 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * xhci-exynos.c - xHCI host controller driver platform Bus Glue for Exynos. > > + * > > + * Copyright (C) 2022 Samsung Electronics Incorporated - http://www.samsung.com > > + * Author: Daehwan Jung <dh10.jung@xxxxxxxxxxx> > > + * > > + * A lot of code borrowed from the Linux xHCI driver. > > > + */ > > + > > +#include <linux/clk.h> > > +#include <linux/dma-mapping.h> > > +#include <linux/module.h> > > +#include <linux/pci.h> > > +#include <linux/of.h> > > +#include <linux/of_device.h> > > +#include <linux/platform_device.h> > > +#include <linux/usb/phy.h> > > +#include <linux/slab.h> > > +#include <linux/phy/phy.h> > > +#include <linux/acpi.h> > > +#include <linux/usb/of.h> > > +#ifdef CONFIG_SND_EXYNOS_USB_AUDIO > > This does not exist. > > Please do not add dead code to Linux kernel. > > > +#include "../../../sound/usb/exynos_usb_audio.h" > > +#include <linux/types.h> > > +#include "xhci-trace.h" > > +#endif > > + > > +#include "../core/hub.h" > > +#include "../core/phy.h" > > +#include "xhci.h" > > +#include "xhci-plat.h" > > +#include "xhci-mvebu.h" > > +#include "xhci-rcar.h" > > +#include "../dwc3/dwc3-exynos.h" > > +#include "../dwc3/exynos-otg.h" > > No, how XHCI is related to dwc3? What if different block provides XHCI, > not DWC3? > > > +#include "xhci-exynos.h" > > +#include <soc/samsung/exynos-cpupm.h> > > This does not exist and does not even compile. > > Please do not send code which does not compile... Also, just in case - > do not send code which compiles but does not work. :) > Hi Krzysztof I'm sorry to confuse you. But, it's just for reference module to introduce new feature. That's why I just submitted source code and header without makefile. It's not going to compiled at all now. Best Regards, Jung Deahwan > > Best regards, > Krzysztof >
