On Thu, Sep 17, 2009 at 05:05:14PM +0400, Sergey Pinaev wrote: > "out of the box" iRiver P7 "doesnt work" with following messages: > sd 0:0:0:0: [sda] Unhandled error code > sd 0:0:0:0: [sda] Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK,SUGGEST_RETRY > end_request: I/O error, dev sda, sector 0 Sergey, thanks for the patch. A few things need fixing though. > "MAX_SECTORS_64" quirk helps. > > "a patch": > --- drivers/usb/storage/unusual_devs.h.orig 2009-09-17 16:57:00 +0400 > +++ drivers/usb/storage/unusual_devs.h 2009-09-17 16:56:35 +0400 This shoudl be done from one level up, see SubmittingPatches > @@ -1836,6 +1836,13 @@ > US_SC_DEVICE, US_PR_DEVICE, NULL, > US_FL_IGNORE_RESIDUE ), > > +/* Reported by Sergey Pinaev <dfo@xxxxxxxx> */ > +UNUSUAL_DEV( 0x4102, 0x1059, 0x0000, 0xFFFF, 0xffff isn't valid, it's BCD, so 0x9999 is the highest. However, please don't include the whole range unless you have reason to believe the whole range is affected. In this case just 0000 should do the trick. Can you send an updated patch and we'll get it included? Thanks! -- Phil Dibowitz phil@xxxxxxxx Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
Attachment:
signature.asc
Description: Digital signature
