Re: [PATCH] Support for new variant of PL2303GS adapter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ +CC: linux-usb ]

On Wed, Mar 02, 2022 at 07:47:17PM +0100, Dawid Buchwald wrote:
> This is the issue I have with recently acquired PL2303 adapter:
> 
> [   70.502848] usb 1-2: new full-speed USB device number 5 using xhci_hcd
> [   70.652523] usb 1-2: New USB device found, idVendor=067b,
> idProduct=23f3, bcdDevice= 6.05
> [   70.652533] usb 1-2: New USB device strings: Mfr=1, Product=2,
> SerialNumber=3
> [   70.652538] usb 1-2: Product: USB-Serial Controller
> [   70.652540] usb 1-2: Manufacturer: Prolific Technology Inc.
> [   70.652543] usb 1-2: SerialNumber: CJAKj19B616
> [   70.674558] usbcore: registered new interface driver usbserial_generic
> [   70.674578] usbserial: USB Serial support registered for generic
> [   70.677490] usbcore: registered new interface driver pl2303
> [   70.677498] usbserial: USB Serial support registered for pl2303
> [   70.677510] pl2303 1-2:1.0: pl2303 converter detected
> [   70.677513] pl2303 1-2:1.0: unknown device type, please report to
> linux-usb@xxxxxxxxxxxxxxx
> 
> Signed-off-by: Dawid Buchwald <buchwald.dawid@xxxxxxxxx>

Thanks for the patch. Looks good, but unfortunately it has been
whitespace damaged (tabs replaced by space, e.g. by your mailer) and
doesn't apply.

I could fix it up for you if you prefer, but it's probably better if
you get this fixed on your end so you're all set for your future
contributions.

Try sending the patch to yourself first and make sure you can apply it
with git-am. Take a look at git-send-email too for sending.

Please also add a "USB: serial: pl2303: " prefix to the Subject line and
shorten the current subject somewhat (e.g. "add support for PL2303GS").

For completeness, please also include the output of "lsusb -v" for this
device. It can replace the log snipped above.

> ---
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index a70fd86f735c..1072f8eb6ab9 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -435,6 +435,7 @@ static int pl2303_detect_type(struct usb_serial *serial)
>                 case 0x105:
>                 case 0x305:
>                 case 0x405:
> +               case 0x605:
>                         /*
>                          * Assume it's an HXN-type if the device doesn't
>                          * support the old read request value.

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux