On 24.2.2022 10.44, Udipto Goswami wrote:
> Hi Pavan, Mathias,
>
> we have tested the patch in the testing environment where initially we were hitting the issue. We don't see any issue after including this.
>
> On 18-02-2022 03:11 pm, Pavan Kondeti wrote:
>> On Thu, Feb 17, 2022 at 03:56:43PM +0200, Mathias Nyman wrote:
>>> xhci_reset() timeout was increased from 250ms to 10 seconds in order to
>>> give Renesas 720201 xHC enough time to get ready in probe.
>>>
>>> xhci_reset() is called with interrupts disabled in other places, and
>>> waiting for 10 seconds there is not acceptable.
>>>
>>> Add a timeout parameter to xhci_reset(), and adjust it back to 250ms
>>> when called from xhci_stop() or xhci_shutdown() where interrupts are
>>> disabled, and successful reset isn't that critical.
>>>
>>> Additionally change the signed integer timeout parameter in
>>> xhci_handshake() to a u64 to match the timeout value we pass to
>>> readl_poll_timeout_atomic()
>>>
>>> Reported-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>>> Reported-by: Pavan Kondeti <quic_pkondeti@xxxxxxxxxxx>
>>> Fixes: 22ceac191211 ("xhci: Increase reset timeout for Renesas 720201 host.")
>>> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>> We have tested the patch and found no issues. Since the issue happens
>> very rarely, we have included in our builds for the wider testing.
>>
>> Thanks,
>> Pavan
Thanks
Can I add a "Tested-by: Pavan Kondeti <quic_pkondeti@xxxxxxxxxxx>" tag?
-Mathias
