Hi, On Wed, Sep 16, 2009 at 09:51:56PM +0200, Francois Romieu wrote: > Andreas Mohr <andi@xxxxxxxx> : > [...] > > Anyway, doesn't change the fact that the r8169 WOL PHY setting is toast > > after every S2R as well ;) > > Stealth tester, he ? Wait, you mean this is the patch to fix it that you created just now, and it's that easy? I'd have expected needing to fiddle with PHY power-management registers and such stuff (while remembering pre-suspend status) upon resume() handlers. And sorry for not reporting it earlier (provoking that "Stealth tester" above, right?), but I had kept tabs on it. > diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c > index 50c6a3c..e0af22f 100644 > --- a/drivers/net/r8169.c > +++ b/drivers/net/r8169.c > @@ -3962,8 +3962,7 @@ static int rtl8169_resume(struct device *device) > goto out; > > netif_device_attach(dev); > - > - rtl8169_schedule_work(dev, rtl8169_reset_task); > + netif_wake_queue(dev); > out: > return 0; > } Crap, this is now the third thing waiting to get patched; looks like I need to do another build for real now. Thanks a lot, Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
