Re: [PATCH v3] usb: gadget: f_uac1: add different speed transfers support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg KH,

Sorry for the trouble, as a new contributor to kernel.
Although I have readed the document that how to submit patches,
I'm still missing some details.

> Where is the patch version information?
The new patch adds more detailed patch description and adds
'static' before 'struct usb_ss_ep_comp_descriptor ac_int_ep_desc_comp'.

> Why are you setting values to 0 when you do not have to as that is the
> default value?
This modification is similar to uac2.
On page 362 of the USB3.2 specification.
bMaxBurst is 0 means that no burst transfer.
bmAttributes is 0 means that no mult.
So the "Maximum number of packets = (bMaxBurst + 1) x (Mult + 1)" is 1.

> The above change is not needed here.
Notice this modification style.

thanks,

Jing Leng




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux