On Wed, Feb 09, 2022 at 03:31:26PM +0200, Heikki Krogerus wrote: > On Tue, Feb 08, 2022 at 05:16:21PM +0800, Xin Ji wrote: > > Add driver for analogix ANX7411 USB Type-C DRP port controller. > > We already have the driver drivers/usb/typec/tcpm/tcpci.c for port > controllers. > > If you need a glue layer - if there is something specific that you > need to do with ANX7411 that is not completely TCPC compliant - use > drivers/usb/typec/tcpm/tcpci_*.c as examples. Hi heikki, ANX7411 PD controller has 2 applications, the one has embeded internal firmware, the other is not have. The currently upstream patch is for the first way, driver mustn't use TCPCI framework(embeded firmware will control all the TCPCI register). The second way(erased internaly firmware) can work under TCPCI framework. Thanks, Xin > > thanks, > > -- > heikki