Re: [PATCH] usb: host: xhci-hub: drop redundant port register reads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/12/22 10:03 AM, Greg Kroah-Hartman wrote:

>> In xhci_hub_control(), there are many port register readbacks in several
>> branches of the *switch* statement which get duplicated right after that
>> *switch* by reading back the port register once more -- which is done to
>> flush the posted writes. Remove the redundant reads inside that *switch*.
> 
> Doing a read right after a write is good, perhaps the one after the
> switch should be removed instead?

   OK, hoping that the PORTPMSC writes don't need the PORTSC readbacks...
   Looking a the git history, the readback after *switch* was redudant from the start... 

> thanks,
> 
> greg k-h

MBR, Sergey




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux