Hello.
Subbrathnam, Swaminathan wrote:
Kevin,
My re-structuring patch would be along similar lines. There are cople of references in the usb.c that need to be re-done (platform specific memorymaps for ex) to be generic across platforms.
I'm not sure I understand what you mean. Across which platfroms?
I am delayed on this patch due to other priorities currently. Will put in an RFC by this week.
And I'm going to recast my stuff ASAP...
regards
swami
________________________________________
From: davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx [davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Kevin Hilman [khilman@xxxxxxxxxxxxxxxxxxx]
Sent: Tuesday, September 15, 2009 1:36 AM
To: Sergei Shtylyov
Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/3] DaVinci: move MUSB platform device to devices.c
Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> writes:
There's absolutely no reason why the DaVinci USB platfrom device should
be in its own module;
Other than devices*.c getting very cluttered, difficult to maintain
and the root cause of merge conflicts because of so many unrleated
patches wanting to touch the same files.
For this reason, as well as to share more between DMx and DA8xx, I
would like to move to a model where devices.c is split up into usb.c,
mmc.c, etc., so I don't like this change.
moreover, it will stand in the way of DA8xx's USB
platfrom device which occupies different region and IRQ -- so, move it
into devices.c and get rid of usb.c...
I'd rather see both DMx and da8xx consolidated into usb.c. In your
patches, there is lots of duplication between those files.
Then usb.c would have all the resource and platform_data for all devices
and the interface would be:
davinci_register_usb() -- renamed from setup_usb()
da8xx_register_usb11()
da8xx_register_usb20()
Kevin
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
