Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Xin Ji <xji@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 8 Feb 2022 09:48:16 +0100
Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, bliang@xxxxxxxxxxxxxxxx, qwen@xxxxxxxxxxxxxxxx, jli@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx
In-reply-to: <20220208084240.3678980-2-xji@analogixsemi.com>
References: <20220208084240.3678980-1-xji@analogixsemi.com> <20220208084240.3678980-2-xji@analogixsemi.com>

On Tue, Feb 08, 2022 at 04:42:39PM +0800, Xin Ji wrote:
> +#define DEBUG

Please no.  Rely on dynamic debugging options, not hard-coded ones like
this.

Please remove this.

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
  - From: Xin Ji

References:
- [PATCH v4 1/2] dt-bindings: usb: Add analogix anx7411 PD binding
  - From: Xin Ji
- [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
  - From: Xin Ji

Prev by Date: [PATCH v4 1/2] dt-bindings: usb: Add analogix anx7411 PD binding
Next by Date: RE: [PATCH] usb: ehci: add pci device support for Aspeed platforms
Previous by thread: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
Next by thread: Re: [PATCH v4 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
Index(es):
- Date
- Thread

[Index of Archives] [Linux Media] [Linux Input] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Old Linux USB Devel Archive]

Powered by Linux