Re: [PATCH 0/8] usb-serial: fix a multitude of problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 Sep 2009, Greg KH wrote:

> On Fri, Sep 11, 2009 at 09:12:39PM -0400, Alan Stern wrote:
> > On Fri, 11 Sep 2009, Greg KH wrote:
> > 
> > > Sorry for the delay, but something seems to have changed recently, and
> > > this doesn't apply on my tree properly.
> > > 
> > > Did I change something?  Any thoughts?  Can you respin these?
> > 
> > You did change something: You applied the two patches Jason Wessel
> > submitted last week.  If you revert them then my patches should apply
> > okay and Jason's first patch will no longer be needed.  His second will
> > need to be rewritten slightly.
> 
> Hm, so are his patches not relevant for .30-stable?  Or do you think
> that both his, and yours, are relevant for it?
> 
> Personally, I think they all are, this is a fricken mess...

I agree with that sentiment.  :-)

2.6.31 isn't going to work properly without something much like my
patch series.  But maybe Jason's patches can get it working better than
it is now -- I can't tell; I haven't tried them out.  And as Alan Cox
often points out, this never did really work entirely correctly.  As
for 2.6.30.stable, I just don't know.  The tty core has been changing 
too quick to keep track of.

Is my series too big for a stable kernel?  It does encompass Jason's
first patch and at least part of his second, maybe all of it.  Perhaps
you should ask him to look at my series and try it out; then he could
see if any of his stuff is still needed and could redo just that
portion.

The one thing I am certain of is that my series is indeed needed for
2.6.32.  It straightens out several messes involving refcounting,
module pinning, hardware initialization, and so on.  Respinning it on
top of Jason's patches wouldn't make any difference; the end state of 
the files would be essentially the same.

Alan Stern

P.S.: To talk of "spinning" patches seems like a mixed metaphor.  One
_sews_ patches, one doesn't _spin_ them.  :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux