On 27.01.22 11:57, Greg KH wrote: > On Thu, Jan 27, 2022 at 11:49:01AM +0100, Oleksij Rempel wrote: >> Add devicetree label property for usbnet devices and related yaml >> schema. > That says _what_ you are doing, but not _why_ you would want to do such > a crazy thing, nor what problem you are attempting to solve here. Hi, could you at least describe what kind of systems we are talking about? Is this for a limited set of embedded devices? Are we talking about devices embedded on a motherboard, which happen to be connected by USB? That is, are we talking about another kind of firmware we are to take information about devices from? And if so, why are you proposing to solve this on the USB driver level? It looks to me like those devices are addressed by their USB path. But still there is no reason that a USB driver should actively interpret firmware stuff that comes from a source that tells us nothing about USB properties. In other words it looks to me like you are trying to put a generic facility for getting device properties into a specific driver. The question whether device names should be read out of firmware is not a USB question. I would suggest you implement a generic facility in the network layer and if everybody is happy with that obviously usbnet can pass through a pointer for that to operate on. Frankly, it looks to me like you are implementing only a subset of what device tree could contain for your specific use case. Regards Oliver
