On Wed, Jan 26, 2022 at 08:08:48AM +0100, Richard Leitner wrote: > On Tue, Jan 25, 2022 at 10:42:45PM +0100, Tommaso Merciai wrote: > > On Mon, Jan 24, 2022 at 07:03:57AM +0000, Richard Leitner - SKIDATA wrote: > > > On Sat, Jan 22, 2022 at 12:26:12AM +0100, Tommaso Merciai wrote: > > > > > > > > + if (!of_property_read_u8(np, "boost-up", &property_u8)){ > > > > + hub->boost_up = property_u8; > > > > > > IMHO we don't need the property_u8 var here as you could pass > > > &hub->boost_up directly to of_property_read_u8() ? > > > > Hi Richard, > > Thanks for your reply. You mean like: > > > > if (!of_property_read_u8(np, "boost-up", &hub->boost_up)) > > exactly. Thanks Richard, I'll send v2. Thanks, Tommaso > > > > > Let me know. I'll fix that in v2. > > > > great! > > thanks & regards;rl