On Tue, Jan 25, 2022 at 05:21:54PM -0800, Jack Pham wrote:
> On Mon, Jan 24, 2022 at 08:01:50AM -0800, Jack Pham wrote:
> > From: Roger Quadros <roger.quadros@xxxxxxxxx>
> >
> > Mac OS-X expects CD-ROM TOC in raw format (i.e. format:2). It also
> > sends the READ_TOC CDB in old style SFF8020i format. i.e. 2 format bits
> > are encoded in MSBs of CDB byte 9.
> >
> > This patch will enable CD-ROM emulation to work with Mac OS-X. Tested on
> > Mac OS X v10.6.3.
> >
> > Signed-off-by: Roger Quadros <roger.quadros@xxxxxxxxx>
> > Signed-off-by: Jack Pham <quic_jackp@xxxxxxxxxxx>
> > ---
> > v4: Updated return length as I had inadvertently applied an earlier version of
> > Roger's patch which had the same mistake [2]
>
> Hi Alan, if this looks fine to you would you please mind providing your
> Acked-by again?
Sure, this is good, a simple fix to the earlier version of the patch.
In fact, I should have noticed the wrong length value while reading it.
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Also, if there are no objections, I think this patch can qualify as a
> bugfix and I can send a v5 Cc'ed to stable with a Fixes tag of commit
> d5e2b67aae79 ("USB: g_mass_storage: template f_mass_storage.c file
> created") -- basically this has been around for as long as
> f_mass_storage.c itself (if not even before when CD-ROM emulation was
> first introduced to the former file_storage gadget).
Whether to call it a bug fix is questionable, because this interface
never worked with Mac OSX. But if you want it to be merged into the
-stable kernels, I have no objection. Greg KH may not agree...
Alan Stern
