On Fri, Jan 21, 2022 at 01:54:28PM -0300, Luiz Sampaio wrote: > The enum led_brightness, which contains the declaration of LED_OFF, > LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports > max_brightness. > --- > drivers/usb/core/ledtrig-usbport.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c > index ba371a24ff78..85fa5699bb3d 100644 > --- a/drivers/usb/core/ledtrig-usbport.c > +++ b/drivers/usb/core/ledtrig-usbport.c > @@ -73,7 +73,7 @@ static void usbport_trig_update_count(struct usbport_trig_data *usbport_data) > > usbport_data->count = 0; > usb_for_each_dev(usbport_data, usbport_trig_usb_dev_check); > - led_set_brightness(led_cdev, usbport_data->count ? LED_FULL : LED_OFF); > + led_set_brightness(led_cdev, usbport_data->count ? 255 : 0); > } > > /*************************************** > @@ -287,12 +287,12 @@ static int usbport_trig_notify(struct notifier_block *nb, unsigned long action, > case USB_DEVICE_ADD: > usbport_trig_add_usb_dev_ports(usb_dev, usbport_data); > if (observed && usbport_data->count++ == 0) > - led_set_brightness(led_cdev, LED_FULL); > + led_set_brightness(led_cdev, 255); > return NOTIFY_OK; > case USB_DEVICE_REMOVE: > usbport_trig_remove_usb_dev_ports(usbport_data, usb_dev); > if (observed && --usbport_data->count == 0) > - led_set_brightness(led_cdev, LED_OFF); > + led_set_brightness(led_cdev, 0); > return NOTIFY_OK; > } > > -- > 2.34.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
