[PATCH 23/24] [Storage] lun_name_format and thread_name added

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A two fsg_config fields were added:
* lun_name_format which lets one specify format of a name
  used when registering LUN devices.  It is useful if there
  would be ever need for two MSFs to be used in a single
  composite gadget (as opposed to single MSF in two
  configuration); and
* thread_name which lets one specify the name of a kernel
  thread used by MSF.  This is not required since two or more
  threads can have the same name but nevertheless it's here
  for consistency.

Signed-off-by: Michal Nazarewicz <m.nazarewicz@xxxxxxxxxxx>
---
 drivers/usb/gadget/f_mass_storage.c |   20 ++++++++++++++++----
 1 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index 33ff65b..49d7baa 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -282,6 +282,8 @@ struct fsg_common {
 	unsigned int		can_stall:1;
 	unsigned int		free_storage_on_release:1;
 
+	const char		*thread_name;
+
 	/* Vendor (8 chars), product (16 chars), release (4
 	 * hexadecimal digits) and NUL byte */
 	char inquiry_string[8 + 16 + 4 + 1];
@@ -299,6 +301,9 @@ struct fsg_config {
 		char cdrom;
 	} luns[FSG_MAX_LUNS];
 
+	const char		*lun_name_format;
+	const char		*thread_name;
+
 	const char *vendor_name;		/*  8 characters or less */
 	const char *product_name;		/* 16 characters or less */
 	u16 release;
@@ -2504,8 +2509,11 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
 		curlun->dev.parent = &gadget->dev;
 		/* curlun->dev.driver = &fsg_driver.driver; XXX */
 		dev_set_drvdata(&curlun->dev, &common->filesem);
-		dev_set_name(&curlun->dev,"%s-lun%d",
-			     dev_name(&gadget->dev), i);
+		dev_set_name(&lun->dev,
+			     cfg->lun_name_format
+			   ? cfg->lun_name_format
+			   : "lun%d",
+			     i);
 
 		rc = device_register(&curlun->dev);
 		if (rc) {
@@ -2570,7 +2578,6 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
 				     ? "File-Stor Gadget"
 				     : "File-CD Gadget  "),
 		 i);
-#undef OR
 
 
 	/* Some peripheral controllers are known not to be able to
@@ -2581,7 +2588,10 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
 		!(gadget_is_sh(fsg->gadget) || gadget_is_at91(fsg->gadget));
 
 
+	common->thread_name = OR(cfg->thread_name, "file-storage");
 	kref_init(&common->ref);
+#undef OR
+
 
 	/* Information */
 	INFO(common, FSG_DRIVER_DESC ", version: " FSG_DRIVER_VERSION "\n");
@@ -2721,7 +2731,7 @@ static int fsg_bind(struct usb_configuration *c, struct usb_function *f)
 
 
 	fsg->thread_task = kthread_create(fsg_main_thread, fsg,
-			"file-storage-gadget");
+					  fsg->common->thread_name);
 	if (IS_ERR(fsg->thread_task)) {
 		rc = PTR_ERR(fsg->thread_task);
 		goto out;
@@ -2864,6 +2874,8 @@ fsg_config_from_params(struct fsg_config *cfg,
 	}
 
 	/* Let FSG use defaults */
+	cfg->lun_name_format = 0;
+	cfg->thread_name = 0;
 	cfg->vendor_name = 0;
 	cfg->product_name = 0;
 	cfg->release = 0xffff;
-- 
1.6.3.3


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux