On Tue, Jan 18, 2022 at 09:02:36AM +0000, Jon Hunter wrote: > > On 17/01/2022 15:40, Greg KH wrote: > > On Mon, Jan 17, 2022 at 03:00:39PM +0000, Jon Hunter wrote: > > > Commit 7495af930835 ("ARM: multi_v7_defconfig: Enable drivers for > > > DragonBoard 410c") enables the CONFIG_PHY_QCOM_USB_HS for the ARM > > > multi_v7_defconfig. Enabling this Kconfig is causing the kernel to crash > > > on the Tegra20 Ventana platform in the ulpi_match() function. > > > > > > The Qualcomm USB HS PHY driver that is enabled by CONFIG_PHY_QCOM_USB_HS, > > > registers a ulpi_driver but this driver does not provide an 'id_table', > > > so when ulpi_match() is called on the Tegra20 Ventana platform, it > > > crashes when attempting to deference the id_table pointer which is not > > > valid. The Qualcomm USB HS PHY driver uses device-tree for matching the > > > ULPI driver with the device and so fix this crash by using device-tree > > > for matching if the id_table is not valid. > > > > > > Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT") > > > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > > > > No cc: of stable since this is a bug going back to 4.11? > > > Yes good point. > > Heikki, let me know if you want me to resend or if you can add the stable > tag? I can add it myself. I'll do so after 5.17-rc1 is out, when I can apply things to my tree. thanks, greg k-h