On Mon, Jan 17, 2022 at 03:46:44PM +0500, Mikhail Gavrilov wrote:
> On Mon, 17 Jan 2022 at 13:58, Heikki Krogerus
> <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> >
> > Hi Mikhail,
> >
> > Thank you for bisecting the problem.
> >
> > The code assumes currently that every USB Type-C port has an ACPI
> > device node defined for it in the ACPI tables, but it looks like we
> > can't make that assumption. Could you send me the acpidump?
> >
> > I'm attaching a test patch where I check the Type-C port ACPI nodes.
> > Let me know it that fixes the problem.
> >
>
> Hi Heikki,
> Unfonitaly I can't test patch because it applicable to actual code base.
>
> $ cat 0001-usb-typec-Test-fix.patch | git apply -v
> Checking patch drivers/usb/typec/port-mapper.c...
> error: while searching for:
> {?
> struct each_port_arg arg = { .port = con, .match = NULL };?
> ?
> bus_for_each_dev(&acpi_bus_type, NULL, &arg, typec_port_match);?
> ?
> /*?
>
> error: patch failed: drivers/usb/typec/port-mapper.c:56
> error: drivers/usb/typec/port-mapper.c: patch does not apply
I don't know which tree you are working on top of, but the patch
applies just fine on top of Linus' latest master branch:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> I attached acpidump files from my workstation and laptop.
Thanks. I can see UCSI in your laptop dump, but not in the workstation
dump. The laptop has the device nodes also for the ports as expected.
Which machine is failing?
Br,
--
heikki
