Quoting Matthias Kaehlcke (2022-01-12 12:51:41) > On Wed, Jan 12, 2022 at 12:47:15PM -0800, Stephen Boyd wrote: > > Quoting Matthias Kaehlcke (2022-01-12 11:10:48) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > > index d4f4441179fc..cd31460b3bd6 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > > @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub { > > > pinctrl-names = "default"; > > > pinctrl-0 = <&en_pp3300_hub>; > > > > > > - regulator-always-on; > > > regulator-boot-on; > > > > Is regulator-boot-on necessary? > > It tells the kernel that the regulator is already on at boot, and avoids an > off-on cycle that would happen otherwise (internal reference: b/185972336). Got it! A comment here would be helpful so we know the BIOS leaves the regulator on.