On Tue, Jan 11, 2022 at 02:15:17PM +0000, Wayne Chang wrote: > Hi Greg, > Thanks for the review. > > On 1/11/22 10:03 PM, Greg KH wrote: > > > > > > On Tue, Jan 11, 2022 at 09:36:43PM +0800, Wayne Chang wrote: > >> From: Sing-Han Chen <singhanc@xxxxxxxxxx> > >> > >> after driver sending the UCSI_START cmd, CCGx would > >> clear Bit 0:Device Interrupt in the INTR_REG if CCGX > >> reset successfully. > >> > >> however, there might be a chance that other bits in > >> INTR_REG are not cleared due to internal data queued > >> in PPM and cause the driver thinks CCGx reset failed. > >> > >> the commit checks bit 0 in INTR_REG and ignore other > >> bits. ucsi driver would reset PPM later. > >> > >> Signed-off-by: Sing-Han Chen <singhanc@xxxxxxxxxx> > >> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx> > >> --- > >> drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > What commit id does this fix? > The change is to fix the defect of ucsi_ccg_init func based on the CCGx > spec. > The original implementation's commit Id is i247c554a14aa1. Great, can you resend this with a proper "Fixes:" tag on it? thanks, greg k-h
