On Wed, Jan 05, 2022 at 04:53:07PM +0800, Jiasheng Jiang wrote: > On Wed, Jan 05, 2022 at 03:30:47PM +0800, Mika Westerberg wrote: > > This is doing two things so I suggest sending two patches instead. > > Fine, I have already sent the patch for icm_handle_event() independently. Thanks! > > However, for the UUID part, I think it works fine if we get NULL (and I > > think kmemdup() issues warning too). > > > > There are probably not needed either since the "fix" here is for pretty > > rare case of running out of memory. I think there is not even a NULL > > pointer dereference because UUID is optional. > > As for icm_icl_set_uuid(), I think the check for kmemdup() is needed. > Because users need to know that icm_start() fails, or they will be puzzled > why the uuid is unsetted. > So at least it is a cleanup. > if so, I would like to send patch for icm_icl_set_uuid() without fixes tag. I don't think icm_start() actually fails because if this. If the UUID is not set tb_switch_add() will look it up from the host router vendor area then. We can log a warning or something like that (but I think that's already done in kmemdup()).
