On 1/4/2022 6:22 AM, Dinh Nguyen wrote:
> We should not be clearing the HCD_FLAG_HW_ACCESSIBLE bit if the hardware
> does not support clock gating.
>
> Fixes: 50fb0c128b6e ("usb: dwc2: Add clock gating entering flow by
> system suspend")
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx>
> ---
> drivers/usb/dwc2/hcd.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 13c779a28e94..f63a27d11fac 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -4399,11 +4399,12 @@ static int _dwc2_hcd_suspend(struct usb_hcd *hcd)
> * If not hibernation nor partial power down are supported,
> * clock gating is used to save power.
> */
> - if (!hsotg->params.no_clock_gating)
> + if (!hsotg->params.no_clock_gating) {
> dwc2_host_enter_clock_gating(hsotg);
>
> - /* After entering suspend, hardware is not accessible */
> - clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
> + /* After entering suspend, hardware is not accessible */
> + clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
> + }
> break;
> default:
> goto skip_power_saving;
