On 26/12/2021 17:31, Andrew Lunn wrote: >>> I've nothing against this patch, but if you are working on the driver, >>> it would be nice to replace these hex numbers with #defines using BIT, >>> or FIELD. It will make the code more readable. >> >> Replacing the constants with macros is on my list of things that I want >> to do. In this case, I did not do it because I wanted to a have small >> patch that gets easily accepted and allows me to figure out the current >> process to submit patches after years of inactivity. > > Agreed, keep fixes simple. > > A few other hints. If you consider this a fix which should be back > ported, please add a Fixes: tag, where the issue started. This can be > back as far as the first commit for the driver. Fixes should also be > sent to the net tree, not net-next. See the netdev FAQ about the two > different trees. I made a v2 of the patch and also added the prefix flag to indicate that the patch is destined for the "next" tree. There is still something that can be improved a about it, please let me know. Otherwise, I will also resend the other patch that I sent for the driver to indicate that it is destined for the "next" tree. Kind regards, Matthias-Christian Ott
