Re: [PATCH] iPhone USB Ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 8. September 2009 01:26:20 schrieb Diego Giagio:

Hi,

> >        usb_clear_halt(udev, usb_rcvbulkpipe(udev, dev->bulk_in));
> >        usb_clear_halt(udev, usb_sndbulkpipe(udev, dev->bulk_out));
> >
> > Is this really needed?
>
> Well, I tried to be as close as possible to the inner workings of
> Apple proprietary driver on Windows, which also does this.

Please try out removing them. If they are indeed needed, a comment
stating that the device is quirky would be called for.

> > static void ipheth_disconnect(struct usb_interface *intf)
> > {
> >        struct ipheth_device *dev;
> >
> >        dev = usb_get_intfdata(intf);
> >        if (dev != NULL) {
> >
> > How can this be NULL?
>
> I'm not sure, perhaps a race between probe/disconnect? Is that
> possible? Or am I just being paranoid? :-)

probe() and disconnect() cannot race.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux