Re: [PATCH v2 00/11] usb: gadget: audio: Multiple rates, dyn. bInterval

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Dne 21. 12. 21 v 8:59 Greg Kroah-Hartman napsal(a):
On Mon, Dec 20, 2021 at 10:11:19PM +0100, Pavel Hofman wrote:
Hi all,

This series implements:
* Support for multiple rates in the audio gadget
* Notification of gadget-side alsa processes about playback/capture
start/stop on the host side via Playback/Capture Rate controls.
* Detection of the USB cable disconnection by handling SUSPEND call
in f_uac1/2. The disconnection generates a stop notification.
* Dynamic bInterval calculation for HS and SS

Patches for the multirate support, originally authored by Julian Scheel,
were rebased and modified for the current code base. Julian has
acknowledged the presented patches.

The detection of cable disconnection was discussed with dwc2 maintainer
Minas Harutyunyan who confirmed that the suspend event can be used
(https://lore.kernel.org/all/5aada8e3-f385-0589-8d58-187abd1a924d@xxxxxxxxxxxx/T/).
Tests on dwc2 have confirmed reliable detection, the gadget correctly
reports playback/capture stop at cable disconnection.

The start/stop/current rate notification feature is accompanied by
example implementation of audio gadget controller
https://github.com/pavhofman/gaudio_ctl. The controller also handles
debouncing fast start/stop events when USB host audio driver is loaded
and/or audio daemon re/started.

Changes:
--------

v2: Fixed compilation of "usb: gadget: f_uac1: Support multiple sampling
rates" - added changes for CONFIG_GADGET_UAC1

I get the following build warning and error with this series applied to
my tree:

drivers/usb/gadget/legacy/audio.c: In function ‘audio_bind’:
drivers/usb/gadget/legacy/audio.c:251:21: error: unused variable ‘i’ [-Werror=unused-variable]
   251 |         int status, i;
       |                     ^
cc1: all warnings being treated as errors

Please fix up.

I am sorry for the inconvenience. I  will send fixed v3 tomorrow.

Thanks for your patience.

Pavel.



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux