On Mon, Dec 20, 2021 at 05:41:22PM +0200, Heikki Krogerus wrote: > On Mon, Dec 20, 2021 at 03:47:56PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Dec 17, 2021 at 05:14:42PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Fri, Dec 17, 2021 at 03:32:59PM +0100, Thorsten Leemhuis wrote: > > > > Lo! Thx for working out a fix this quickly! > > > > > > > > I'm just the regression tracker, but I think there are a few minor > > > > details to improve here. > > > > > > > > On 17.12.21 15:03, Heikki Krogerus wrote: > > > > > The driver must make sure there is an actual connection > > > > > before checking details about the USB Power Delivery > > > > > contract. Those details are not valid unless there is a > > > > > connection. > > > > > > > > > > This fixes NULL pointer dereference that is caused by an > > > > > attempt to register bogus partner alternate mode that the > > > > > firmware on some platform may report before the actual > > > > > connection. > > > > > > > > > > Fixes: 6cbe4b2d5a3f ("usb: typec: ucsi: Check the partner alt modes always if there is PD contract") > > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215117 > > > > BugLink? Is that a tag we really use? Then I'm unaware of it. Greg is > > > > the expert and can likely clarify, but that line afaik needs to replaced > > > > by this: > > > > > > Although not yet documented, it is the appropriate tag for the link to > > > the bug. It makes it clear that the link is to the bug and not to > > > the discussion on the list. > > > > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215117 > > > > Link: > > > > https://lore.kernel.org/linux-usb/bug-215117-208809@xxxxxxxxxxxxxxxxxxxxxxxxx%2F/ > > > > > > > > Normally the last line would need a 's!linux-usb!r!', but seems the > > > > kernel.org redirector doesn't work well in this particular case, so I > > > > guess it's better this way than not at all :-/ > > > > > > > > The second line will also make the regression tracking bot automatically > > > > close the issue (but I fear it might also fail due to the slash at the > > > > end of the message-id :-/) > > > > > > Greg will add the "Link" tag to the commit when, and if, he actually > > > takes the patch. I do not add it because I do not want any bots to > > > react to the patch before it has actually been accepted. > > > > The link my scripts add is to the post on lore.kernel.org, not to > > anywhere else. > > > > So if this needs to point to a different report, like Thorsten shows > > above, then that needs to be done "by hand". > > > > I guess I'll go add these on my own :( > > OK... so I don't prepare v2 then. No, please do, I will not get to this for another few days because it takes me more work :)