On 3.10.2021 3.14, Nikolay Martynov wrote:
> Tested on SD5200T TB3 dock which has Fresco Logic FL1100 USB 3.0 Host
> Controller.
> Before this patch streaming video from USB cam made mouse and keyboard
> connected to the same USB bus unusable. Also video was jerky.
> With this patch streaming video doesn't have any effect on other
> periferals and video is smooth.
>
> Signed-off-by: Nikolay Martynov <mar.kolya@xxxxxxxxx>
> ---
> drivers/usb/host/xhci-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 2c9f25ca8edd..2175fac2f259 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -30,6 +30,7 @@
> #define PCI_VENDOR_ID_FRESCO_LOGIC 0x1b73
> #define PCI_DEVICE_ID_FRESCO_LOGIC_PDK 0x1000
> #define PCI_DEVICE_ID_FRESCO_LOGIC_FL1009 0x1009
> +#define PCI_DEVICE_ID_FRESCO_LOGIC_FL1100 0x1100
> #define PCI_DEVICE_ID_FRESCO_LOGIC_FL1400 0x1400
>
> #define PCI_VENDOR_ID_ETRON 0x1b6f
> @@ -113,6 +114,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> /* Look for vendor-specific quirks */
> if (pdev->vendor == PCI_VENDOR_ID_FRESCO_LOGIC &&
> (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK ||
> + pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_FL1100 ||
> pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_FL1400)) {
> if (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK &&
> pdev->revision == 0x0)
I'm getting reports that this patch causes issues detecting usb drives connected to a dock
with this Fresco FL1100 xHC.
This patch adds both XHCI_TRUST_TX_LENGTH and XHCI_BROKEN_MSI quirks, which was probably
not intended. Removing the BROKEN_MSI quirk solved the issue.
Does you setup work normally with just TRUST_TX_LENGTH quirk?
-Mathias
