On 29/11/2021 19:56, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Nov 08, 2021 at 03:05:43PM +0000, conor.dooley@xxxxxxxxxxxxx wrote: >> From: Ivan Griffin <ivan.griffin@xxxxxxxxxxxxx> >> >> Add device tree bindings for the Microchip Polarfire Soc interrupt >> controller >> >> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> Signed-off-by: Ivan Griffin <ivan.griffin@xxxxxxxxxxxxx> >> --- >> .../microchip,mpfs-plic.h | 199 ++++++++++++++++++ >> 1 file changed, 199 insertions(+) >> create mode 100644 include/dt-bindings/interrupt-controller/microchip,mpfs-plic.h > > Notice how there are not SoC interrupt defines in this directory. That's > because we don't do defines for them. The 'rule' is only defines for > made up numbers which are not in a reference manual. Oh fair enough, I will drop these changes for V2 so. Thanks. > > Rob >