Re: [patch 2/2] musb: davinci dm6446evm GPIO renumbering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Kevin Hilman wrote:

From: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>

Numbering for GPIOs on the pcf857x chips on the dm644x EVM board
changed when DaVinci chips with more GPIOs were supported.  Update
the GPIO number used for nVBUS_DRV.

Longer term, we need a better abstraction of board-specific setup in
this code so we're not hard-coding board specific GPIOs into the
driver, but for now this at least gets it back to working with
mainline davinci core code.

Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>

[...]

--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -42,7 +42,7 @@
#include "musb_core.h"
 #ifdef CONFIG_MACH_DAVINCI_EVM
-#define GPIO_nVBUS_DRV		87
+#define GPIO_nVBUS_DRV		144

 Somehow this leads to an oops for me in 2.6.31-rc8. 120 does work...

Hmm, this change probably should've been queued for 2.6.32 instead
since the IRQ numbering change is queued for .32.

No, it just should have renumbered the GPIO in question to 120, only taking into account DaVinci's 104 GPIOs, not DA830/OMAP-L137's 128. I've sent out the patch correcting the number yesterday.

Kevin

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux