On Thu, Nov 25, 2021 at 04:42:27PM +0100, Maarten Brock wrote:
> Hello all,
>
> When a uart of the CP2105 USB-serial chip is programmed to be in modem
> mode, all its gpio pins are in alternate use and none are available for
> gpio. Still the cp210x driver tries to add a gpiochip unconditionally,
> which results in an error.
>
> > cp210x 1-1.4.4:1.0: cp210x converter detected
> > usb 1-1.4.4: cp210x converter now attached to ttyUSB0
> > cp210x 1-1.4.4:1.1: cp210x converter detected
> > gpio gpiochip2: (cp210x): tried to insert a GPIO chip with zero lines
> > gpiochip_add_data_with_key: GPIOs 0..-1 (cp210x) failed to register,
> > -22
> > cp210x 1-1.4.4:1.1: GPIO initialisation failed: -22
> > usb 1-1.4.4: cp210x converter now attached to ttyUSB1
Thanks for reporting this.
> I propose to add something like the following to cp210x_gpio_init
>
> + unsigned long valid_mask, altfunc_mask;
> ...
> + altfunc_mask = priv->gpio_altfunc;
> + bitmap_complement(&valid_mask, &altfunc_mask, priv->gc.ngpio);
> + if (bitmap_empty(&valid_mask, priv->gc.ngpio))
> + return 0;
> +
> priv->gc.label = "cp210x";
> priv->gc.request = cp210x_gpio_request;
> priv->gc.get_direction = cp210x_gpio_direction_get;
>
> I can write a proper patch, but am unsure if and what the Fixes tag
> should be.
This was introduced by commit c8acfe0aadbe ("USB: serial: cp210x:
implement GPIO support for CP2102N") when generalising GPIO support and
adding support for CP2102N. Before that commit, the GPIO chip would
indeed never have been registered in this case.
The right fix however is to continue to always register the gpiochip but
to make sure that the number of lines is initialised before doing so.
This is how we deal with with the other device types and is also how
CP2105 is handled when both pins of the CP2105 ECI port are muxed for
LED function.
I've just posted a fix here:
https://lore.kernel.org/r/20211126094348.31698-1-johan@xxxxxxxxxx
Johan
