Hi Prashant, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on linux/master linus/master peter-chen-usb/for-usb-next v5.16-rc2 next-20211124] [cannot apply to balbi-usb/testing/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Prashant-Malani/usb-Use-notifier-for-linking-Type-C-ports/20211125-071439 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-defconfig (https://download.01.org/0day-ci/archive/20211125/202111251010.fxed9VtQ-lkp@xxxxxxxxx/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/d56a1c2271ef9c1877e9400fb1adc5adbb278e51 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Prashant-Malani/usb-Use-notifier-for-linking-Type-C-ports/20211125-071439 git checkout d56a1c2271ef9c1877e9400fb1adc5adbb278e51 # save the config file to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from drivers/usb/core/port.c:12: >> include/linux/usb/typec.h:322:5: warning: no previous prototype for 'typec_port_registration_register_notify' [-Wmissing-prototypes] 322 | int typec_port_registration_register_notify(struct notifier_block *nb) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> include/linux/usb/typec.h:327:5: warning: no previous prototype for 'typec_port_registration_unregister_notify' [-Wmissing-prototypes] 327 | int typec_port_registration_unregister_notify(struct notifier_block *nb) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/typec_port_registration_register_notify +322 include/linux/usb/typec.h ed296d8d0a92758 Prashant Malani 2021-11-24 321 ed296d8d0a92758 Prashant Malani 2021-11-24 @322 int typec_port_registration_register_notify(struct notifier_block *nb) ed296d8d0a92758 Prashant Malani 2021-11-24 323 { ed296d8d0a92758 Prashant Malani 2021-11-24 324 return 0; ed296d8d0a92758 Prashant Malani 2021-11-24 325 } ed296d8d0a92758 Prashant Malani 2021-11-24 326 ed296d8d0a92758 Prashant Malani 2021-11-24 @327 int typec_port_registration_unregister_notify(struct notifier_block *nb) ed296d8d0a92758 Prashant Malani 2021-11-24 328 { ed296d8d0a92758 Prashant Malani 2021-11-24 329 return 0; ed296d8d0a92758 Prashant Malani 2021-11-24 330 } ae196ddb0d3186b Heikki Krogerus 2021-04-07 331 #endif ae196ddb0d3186b Heikki Krogerus 2021-04-07 332 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx