On 22.11.2021 14.27, Marek Szyprowski wrote: > Hi, > > On 22.11.2021 11:50, Mathias Nyman wrote: >> Fix the circular lock dependency and unbalanced unlock of addess0_mutex >> introduced when fixing an address0_mutex enumeration retry race in commit >> ae6dc22d2d1 ("usb: hub: Fix usb enumeration issue due to address0 race") >> >> Make sure locking order between port_dev->status_lock and address0_mutex >> is correct, and that address0_mutex is not unlocked in hub_port_connect >> "done:" codepath which may be reached without locking address0_mutex >> >> Fixes: 6ae6dc22d2d1 ("usb: hub: Fix usb enumeration issue due to address0 race") >> Cc: <stable@xxxxxxxxxxxxxxx> >> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > This fixes the issue I've reported here: > https://lore.kernel.org/all/f3bfcbc7-f701-c74a-09bd-6491d4c8d863@xxxxxxxxxxx/ > Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> Thank you for testing, I'll add these tags -Mathias