On 11/5/21 1:52 AM, Greg KH wrote:
> On Fri, Nov 05, 2021 at 04:33:57PM +0800, Haimin Zhang wrote:
>> In function `ehci_brcm_hub_control`, like following code,
>> it filters out the case where the upper byte of wIndex is nonzero,
>> so it need be replaced with temp.
>
> I do not understand this text, can you try to reword it?
>
> And you have trailing whitespace.
>
> And why use `?
>
>> ```
>
> What is this for? Changelog comments are not in markdown format.
>
>> if ((typeReq == GetPortStatus) &&
>> (wIndex && wIndex <= ports) && // need to be replaced
>
> What does this comment mean?
>
>> ehci->reset_done[wIndex-1] &&
>> time_after_eq(jiffies, ehci->reset_done[wIndex-1]) &&
>> (ehci_readl(ehci, status_reg) & PORT_RESUME)) {
>> ```
>>
>> Signed-off-by: Haimin Zhang <tcs_kernel@xxxxxxxxxxx>
>> Reported-by: TCS Robot <tcs_robot@xxxxxxxxxxx>
>
> Again, lines need to be in different order, and your from: line is not
> correct.
>
> Also, you need an individual email address, not a group email alias for
> your contributions. We work with individuals, not groups.
Also, would you mind copying the people who are remotely involved with
this piece of code, like Al? Thank you
--
Florian
