On 28/10/2021 22:46, Bryan O'Donoghue wrote:
I thought it would be a mess to have, since we try to keep addresses linear in DTS files
sic: I thought the following DTS would be messy since the tcpm device would span over all three silicon blocks and should we want to add in charger, the charger would then end up as an out-of-order address.
pm8150b_tcpm: pmic-tcpm@1500 { compatible = "qcom,pmic-tcpm"; pm8150b_typec: typec@1500 { compatible = "qcom,pm8150b-typec"; reg = <0x1500>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_typec: endpoint { remote-endpoint = <&pmic_tcpm_typec>; }; }; }; }; pm8150b_pdphy: pdphy@1700 { compatible = "qcom,pm8150b-pdphy"; reg = <0x1700>; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; pmic_pdphy: endpoint { remote-endpoint = <&pmic_tcpm_pdphy>; }; }; }; }; }; pm8150b_charger: pmic-charger@1600 { /* Consume electrons here */ };