Hi Sergey
On 10/26/21 7:39 PM, Sergey Shtylyov wrote:
> If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
> the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
> at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...
>
> Fixes: e47c5a0906f9 ("usb: host: ehci-st: Add EHCI support for ST STB devices")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
> Changes in version 2:
> - added Alan's ACK.
>
> drivers/usb/host/ehci-st.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
> index f74433aac948..5f53c313f943 100644
> --- a/drivers/usb/host/ehci-st.c
> +++ b/drivers/usb/host/ehci-st.c
> @@ -160,6 +160,8 @@ static int st_ehci_platform_probe(struct platform_device *dev)
> irq = platform_get_irq(dev, 0);
> if (irq < 0)
> return irq;
> + if (!irq)
> + return -EINVAL;
> res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> if (!res_mem) {
> dev_err(&dev->dev, "no memory resource provided");
>
Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
Thanks
Patrice
