Re: [PATCH] usb: remove res2 argument from gadget code completions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 25, 2021 at 09:23:58AM -0600, Jens Axboe wrote:
> The USB gadget code is the only code that every tried to utilize the
> 2nd argument of the aio completions, but there are strong suspicions
> that it was never actually used by anything on the userspace side.
> 
> Out of the 3 cases that touch it, two of them just pass in the same
> as res, and the last one passes in error/transfer in res like any
> other normal use case.
> 
> Remove the 2nd argument, pass 0 like the rest of the in-kernel users
> of kiocb based IO.
> 
> Link: https://lore.kernel.org/linux-block/20211021174021.273c82b1.john@xxxxxxxxxxxx/
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> 
> ---
> 
> Greg/John - if you guys are fine with this patch, let me know. I've got
> the ->ki_complete() argument removal sitting on top of this.

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux