Hello! On 10/19/21 8:41 AM, Greg Kroah-Hartman wrote: >> Here are 22 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo. >> The affected drivers use platform_get_irq() which can return IRQ0 (considered >> invalid, according to Linus) that means broken HCD when passed to usb_add_hcd() >> called at the end of the probe methods. I think that the solution to this issue >> is either explicitly deny or accept IRQ0 in usb_add_hcd()... /but/ here's this >> patch set to get the things going... > > Why not fix the root of the problem for your platform that is failing to > assign a valid irq for the device? I'm just auditing the existing code, not developing on a new platform. (I also don't share Linus' opinion on IRQ0, TBH.) > Are you going to make this change to all callers of this function in the > kernel tree? No, only to those drivers that reinterpret IRQ0 as something other, e.g. polling (only libata so far). No change needed to the subsystem that call request_irq() and its ilk w/o filtering out IRQ0. > thanks, > > greg k-h MBR, Sergey
