Re: [PATCH 00/22] Explicitly deny IRQ0 in the USB host drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 19, 2021 at 07:41:34AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Oct 18, 2021 at 09:39:08PM +0300, Sergey Shtylyov wrote:
> > Here are 22 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo.
> > The affected drivers use platform_get_irq() which can return IRQ0 (considered
> > invalid, according to Linus) that means broken HCD when passed to usb_add_hcd()
> > called at the end of the probe methods. I think that the solution to this issue
> > is either explicitly deny or accept IRQ0 in usb_add_hcd()... /but/ here's this
> > patch set to get the things going...
> 
> Why not fix the root of the problem for your platform that is failing to
> assign a valid irq for the device?
> 
> Are you going to make this change to all callers of this function in the
> kernel tree?

Also, you should have gotten a huge WARNING in your kernel log if this
happens to let you know that something bad is going on.  Is this patch
series going to really change any of that?

What is the root problem here that you are trying to paper over with
this patchset?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux