On 15.10.21 10:52, Juergen Gross wrote:
On 15.10.21 10:14, Greg KH wrote:On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote:On 13.10.21 14:01, Greg KH wrote:On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:Add the definition of pvUSB protocol used between the pvUSB frontend in a Xen domU and the pvUSB backend in a Xen driver domain (usually Dom0).This header was originally provided by Fujitsu for Xen based on Linux 2.6.18. Changes are: - adapt to Linux kernel style guide - use Xen namespace - add lots of comments - don't use kernel internal defines Signed-off-by: Juergen Gross <jgross@xxxxxxxx> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> ---include/xen/interface/io/usbif.h | 421 +++++++++++++++++++++++++++++++1 file changed, 421 insertions(+) create mode 100644 include/xen/interface/io/usbif.hdiff --git a/include/xen/interface/io/usbif.h b/include/xen/interface/io/usbif.hnew file mode 100644 index 000000000000..9494b1c9be99 --- /dev/null +++ b/include/xen/interface/io/usbif.h @@ -0,0 +1,421 @@ +/* + * usbif.h + * + * USB I/O interface for Xen guest OSes. + * + * Copyright (C) 2009, FUJITSU LABORATORIES LTD. + * Author: Noboru Iwamatsu <n_iwamatsu@xxxxxxxxxxxxxx> + *+ * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is+ * furnished to do so, subject to the following conditions: + *+ * The above copyright notice and this permission notice shall be included in+ * all copies or substantial portions of the Software. + *+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER+ * DEALINGS IN THE SOFTWARE. + */Please use a SPDX line and not license "boilerplate" text like this :(Okay. Is this your only concern for this series? Or is it a blocking point for you before looking into it in more detail?It was an easy thing to see at first glance that you hadn't taken my previous comment about this seriously :(I'm sorry for that. This was clearly an oversight from me. BTW, when checking which SPDX tag to use I discovered that most of the Xen header files under include/xen/interface have been tagged as GPL-2.0 by a patch from you. Said patch (commit b24413180f5600) stated that there was no license information found in those files, but they all clearly had a verbatim copy of the MIT license in them.
They didn't. No idea where I was seeing that, sorry for that wrong statement. Nevertheless the GPL-2.0 tag is wrong for those files. Clearly need more coffee. :-(
I'll send another patch fixing those SPDX tags.
Juergen
Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
