Re: [PATCH 1/1] usb: xhci: Enable runtime-pm by default on AMD Yellow Carp platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.10.2021 19.42, Greg KH wrote:
> On Wed, Oct 13, 2021 at 06:16:33PM +0300, Mathias Nyman wrote:
>> From: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@xxxxxxx>
>>
>> AMD's Yellow Carp platform supports runtime power management for
>> XHCI Controllers, so enable the same by default for all XHCI Controllers.
>>
>> Signed-off-by: Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@xxxxxxx>
>> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
>> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
>> Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
>> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
>> ---
>>  drivers/usb/host/xhci-pci.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
>> index 2c9f25ca8edd..0e571d6af2ab 100644
>> --- a/drivers/usb/host/xhci-pci.c
>> +++ b/drivers/usb/host/xhci-pci.c
>> @@ -69,6 +69,12 @@
>>  #define PCI_DEVICE_ID_ASMEDIA_1142_XHCI			0x1242
>>  #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI			0x2142
>>  #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI			0x3242
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1	0x161a
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2	0x161b
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3	0x161d
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4	0x161e
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5	0x15d6
>> +#define PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6	0x15d7
> 
> Please keep the ids aligned whenever possible.  Why is there not 2 tabs
> being used here?

I'll fix that  and resend 

-Mathias




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux