Re: Query: usbtest: parameter "pattern" is read-only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Aug 2009, Gadiyar, Anand wrote:

> Hi all,
> 
> static unsigned pattern = 0;
> module_param (pattern, uint, S_IRUGO);
> MODULE_PARM_DESC(pattern, "i/o pattern (0 == zeroes)");
> 
> In drivers/usb/misc/usbtest.c, is there any reason the module
> parameter "pattern" is read-only?

I imagine it is read-only because you'd get into trouble if the value 
was changed while a test was running.

> Is it okay to submit a patch making it writeable at run-time?

You should ask the driver's author: David Brownell.  Probably a safe 
way to change it would be to copy the value at the beginning of a test 
and then use that copied value throughout the test.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux