Re: [PATCH] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/12/2021 1:02 PM, Greg Kroah-Hartman wrote:
On Mon, Oct 11, 2021 at 03:31:57PM +0530, Sandeep Maheswaram wrote:
dwc3 manages PHY by own DRD driver, so skip the management by
HCD core.
During runtime suspend phy was not getting suspend because
runtime_usage value is 2.

Signed-off-by: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx>
---
  drivers/usb/dwc3/host.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f29a264..0921f05 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -11,6 +11,11 @@
  #include <linux/platform_device.h>
#include "core.h"
+#include "../host/xhci-plat.h"
Why are you tying the dwc3 driver to the xhci driver?

Can we add a  property usb-skip-phy-init  in drivers/usb/dwc3/host.c

props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");

and set the quirk like this in xhci-plat.c

if (device_property_read_bool(tmpdev, "usb-skip-phy-init"))
            xhci->quirks |= XHCI_SKIP_PHY_INIT;

as below

if (device_property_read_bool(tmpdev, "usb2-lpm-disable"))
            xhci->quirks |= XHCI_HW_LPM_DISABLE;

 if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
            xhci->quirks |= XHCI_LPM_SUPPORT;



+
+static const struct xhci_plat_priv xhci_plat_dwc3_xhci = {
+	.quirks = XHCI_SKIP_PHY_INIT,
If these quirks are now "global", they should go into a
include/linux/usb/ .h file, right?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux