Re: [PATCH] usb-storage: Add compatibility quirk flags for iODD 2531/2541

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 13, 2021 at 08:55:04PM -0500, James Buren wrote:
> These drive enclosures have firmware bugs that make it impossible to mount
> a new virtual ISO image after Linux ejects the old one if the device is
> locked by Linux. Windows bypasses this problem by the fact that they do
> not lock the device. Add a quirk to disable device locking for these
> drive enclosures.
> 
> Signed-off-by: James Buren <braewoods+lkml@xxxxxxxxxxxxx>
> ---

In the future, you should always include a version number in the email 
Subject: line (for example, "[PATCH v2]") so that readers will know 
which patch is which.  And you should include, here just below the "---" 
line, a description of how this version differs from the previous 
version.  See the email archives for examples of multi-version patches.

Nevertheless, this looks okay.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

>  drivers/usb/storage/unusual_devs.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index c6b3fcf90180..29191d33c0e3 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -406,6 +406,16 @@ UNUSUAL_DEV(  0x04b8, 0x0602, 0x0110, 0x0110,
>  		"785EPX Storage",
>  		USB_SC_SCSI, USB_PR_BULK, NULL, US_FL_SINGLE_LUN),
>  
> +/*
> + * Reported by James Buren <braewoods+lkml@xxxxxxxxxxxxx>
> + * Virtual ISOs cannot be remounted if ejected while the device is locked
> + * Disable locking to mimic Windows behavior that bypasses the issue
> + */
> +UNUSUAL_DEV(  0x04c5, 0x2028, 0x0001, 0x0001,
> +		"iODD",
> +		"2531/2541",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE),
> +
>  /*
>   * Not sure who reported this originally but
>   * Pavel Machek <pavel@xxxxxx> reported that the extra US_FL_SINGLE_LUN
> -- 
> 2.25.1



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux